Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider Astropy 4 and Numpy 0.17 #1211

Closed
kosack opened this issue Jan 9, 2020 · 4 comments
Closed

consider Astropy 4 and Numpy 0.17 #1211

kosack opened this issue Jan 9, 2020 · 4 comments
Milestone

Comments

@kosack
Copy link
Contributor

kosack commented Jan 9, 2020

Astropy 4.0 was just released. It shouldn't cause any major changes to ctapipe, but there is one new feature that is perhaps useful. If used with NumPy 0.17+, units now work correctly with all numpy ufuncs, which makes some of the hack-work of stripping off units, storing a unit and then re-applying it later in an algorithm no longer needed.

See http://docs.astropy.org/en/stable/whatsnew/4.0.html#major-improvements-in-compatibility-of-quantity-objects-with-numpy-functions

So in the future, we might consider setting the minimum astropy/numpy version in the package and setup.py so that we can use this. Currently we have the required versions set lower.

@kosack
Copy link
Contributor Author

kosack commented Jan 17, 2020

see #1213 and #1212

@kosack
Copy link
Contributor Author

kosack commented Feb 11, 2020

seems to work with both now.

@kosack kosack closed this as completed Feb 11, 2020
@maxnoe
Copy link
Member

maxnoe commented Feb 11, 2020

Actually, I would reopen this issue.

I understood the question not to make ctapipe compatible with the new astropy, but actually require it to simplify unit code.

What do you think?

@kosack kosack reopened this Feb 12, 2020
@kosack
Copy link
Contributor Author

kosack commented Feb 12, 2020

I'm ok with requiring it! Actually, with the changes we have made, it probably is required now. I haven't tried it with astropy<4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants