Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check state and exit code of jobs scheduled by autocloser #263

Closed
morcuended opened this issue Dec 12, 2023 · 1 comment
Closed

Check state and exit code of jobs scheduled by autocloser #263

morcuended opened this issue Dec 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@morcuended
Copy link
Member

Right now there is no way of knowing whether jobs launched by autocloser finished OK or not, unless manually checked.

This can lead to unnoticed problems in the merging of files, as happened for 2023-12-11 (see cta-observatory/cta-lstchain#1193). The DL1 merging job failed for one run, but the file was halfway produced.

The update_source_catalog script reads these DL1 merged files but does not check if the merging script finished properly.

@morcuended morcuended changed the title Check status of jobs scheduled by autocloser Check state and exit code of jobs scheduled by autocloser Dec 12, 2023
@morcuended morcuended added the enhancement New feature or request label Dec 13, 2023
@morcuended
Copy link
Member Author

Also even if there is a dependency on the long-term dl1 check script after all run-wise dl1 data check files are produced, I think sometimes, it is still executed regardless of the exit code of some of the previous jobs. Make sure that this does not happen, for example, launching these lstchain scripts using a bash script with set -e to capture the failing exit at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants