Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDU names in fits containing extracted waveform and charge #54

Closed
sona-patel opened this issue Apr 11, 2023 · 4 comments · Fixed by #59
Closed

HDU names in fits containing extracted waveform and charge #54

sona-patel opened this issue Apr 11, 2023 · 4 comments · Fixed by #59

Comments

@sona-patel
Copy link
Contributor

Output fits files generated from load_wfs_compute_charge.py do not have names for any of the hdus (eg. shown below for charge_run3936.fits).

charge_run3936

Wouldn't it be nice to give them a meaningful name?

Thanks!
@jlenain
Copy link
Collaborator

jlenain commented Apr 14, 2023

Thanks for reporting this, @sona-patel .
@guillaumegrolleron , could you please have a look ?

@guillaumegrolleron guillaumegrolleron mentioned this issue Apr 25, 2023
Merged
@guillaumegrolleron
Copy link
Contributor

Hi @sona-patel , @jlenain ,
#59 is answering this issue

@jlenain
Copy link
Collaborator

jlenain commented Apr 27, 2023

Hi !
Thanks a lot, @guillaumegrolleron !
@sona-patel , here are the resulting extension names:
Screenshot from 2023-04-27 22-57-05
Screenshot from 2023-04-27 22-57-56

@jlenain
Copy link
Collaborator

jlenain commented Apr 27, 2023

Solved in #59

@jlenain jlenain closed this as completed Apr 27, 2023
@jlenain jlenain linked a pull request Apr 27, 2023 that will close this issue
Names for charges and waveforms container extension in fits files #59
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Names for charges and waveforms container extension in fits files guillaumegrolleron/nectarchain
3 participants
@jlenain @sona-patel @guillaumegrolleron