Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

energy_bias_resolution_from_energy_dispersion still assumes wrong normalization of EDISP #267

Open
Tobychev opened this issue Oct 17, 2023 · 1 comment
Open

energy_bias_resolution_from_energy_dispersion still assumes wrong normalization of EDISP #267

Tobychev opened this issue Oct 17, 2023 · 1 comment

Comments

@Tobychev
Copy link
Contributor

Plotting the bias+1 from energy_bias_resolution_from_energy_dispersion on top of the energy bias matrix gives the following result:
Screenshot of a comment on a GitHub issue showing an image, added in the Markdown, of an Octocat smiling and raising a tentacle.

where the blue line and the red line are both estimates of the median in each column of the matrix. The red curve produced using the numpy percentile function using the 'median_unbiased' method (the recommended method in the paper numpy references but for some reason not the default value).
@maxnoe maxnoe changed the title energy_bias_resolution_from_energy_dispersion provides poor estimates energy_bias_resolution_from_energy_dispersion still assumes wrong normalization of EDISP Oct 19, 2023
@maxnoe maxnoe mentioned this issue Oct 19, 2023
Merged
@Tobychev
Copy link
Contributor Author

Fixed by #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tobychev