Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making this work for multiple queries and search results from rocksdb indexes #2

Open
bluegenes opened this issue Feb 1, 2024 · 1 comment

Comments

@bluegenes
Copy link

Differences to account for:

  1. no query_filename in output gather file
  2. no rank in output gather (though we will get this with core updates coming in MRG: use core Collection and Select for sig loading sourmash-bio/sourmash_plugin_branchwater#197)
  3. multiple queries = need to load each query as it is needed
@ctb
Copy link
Owner

ctb commented Feb 1, 2024

in multigather output:

Differences to account for:

1. no `query_filename` in output gather file

what!? argh.

2. no `rank` in output gather  (though we will get this with core updates coming in [WIP: use core Collection and Select for sig loading sourmash-bio/sourmash_plugin_branchwater#197](https://github.com/sourmash-bio/sourmash_plugin_branchwater/pull/197))

the order should be the rank, tho, right?

3. multiple queries  = need to load each query as it is needed

well, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants