Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rake dependency #666

Closed
richard-viney opened this issue Oct 1, 2019 · 4 comments
Closed

Update rake dependency #666

richard-viney opened this issue Oct 1, 2019 · 4 comments
Labels

Comments

@richard-viney
Copy link

As of annotate 3.0.2 the rake dependency in the Gemspec specifies < 13. However, rake 13.0 was recently released and the only breaking change was dropping Ruby versions prior to 2.2. See https://github.com/ruby/rake/blob/master/History.rdoc.

Relaxing this version cap to < 14 should be safe to do and would allow apps to use the latest version of rake.

Thanks!

Version

  • annotate 3.0.2
  • rails 6.0.0
  • ruby 2.5.3p105
@drwl
Copy link
Collaborator

drwl commented Oct 2, 2019

@richard-viney thanks for reporting, I just merged in #659 so develop branch should be able to work for now.

@drwl drwl added the reviewed label Oct 2, 2019
@openscript
Copy link

The annotate gem forced my environment to downgrade the rake version, which broke my test environment.

Gem::LoadError: You have already activated rake 13.0.0, but your Gemfile requires rake 12.3.3. Prepending `bundle exec` to your command may solve this.

I confirm that #659 fixes the issue! 👍

Thank you :)

@drwl
Copy link
Collaborator

drwl commented Nov 9, 2019

I cut a release for 3.0.3 that includes PR #659 so let me know if that doesn't work. @openscript @richard-viney

@drwl
Copy link
Collaborator

drwl commented Dec 17, 2019

Seems like it works so closing this for now. Feel free to reopen.

@drwl drwl closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants