Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated util.pump, it's going away. #87

Open
ChALkeR opened this issue Aug 25, 2015 · 0 comments
Open

Do not use deprecated util.pump, it's going away. #87

ChALkeR opened this issue Aug 25, 2015 · 0 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Aug 25, 2015

util.pump was deprecated since nodejs v0.10, and there is an ongoing discussion on removing that in the next major version: nodejs/node#2531.

The lines in question: /lib/monitor.js#L76-81:

util.pump(readStream, res, function (e) {
    if(e) {
        console.error(e.stack || e);
    }
    res.end();
});

I am not making a pull request because I am not a user of this package and have not tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant