Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin-dotnet: Support for .NET Standard 2.0 #259

Closed
rafaelromao opened this issue Aug 23, 2017 · 6 comments
Closed

gherkin-dotnet: Support for .NET Standard 2.0 #259

rafaelromao opened this issue Aug 23, 2017 · 6 comments

Comments

@rafaelromao
Copy link

Summary

.NET Standard 2.0 is not supported.

Trying to use the Gherkin parser under .NET Core 2.0 and .NET Standard 2.0 will cause a fallback to .NET 4.x and the parser will try and fail to load System.Web.Extensions.

Expected Behavior

Parse feature files successfully using .NET Core 2.0 and .NET Standard 2.0.

Current Behavior

Considering a web project targeting netcoreapp2.0 that consumes a library targeting netstandard2.0 and this library tries to use the Gherkin parser.

The parser try to load System.Web.Extensions on Gherkin.GherkinDialectProvider.ParseJsonContent() and fail with a System.IO.FileNotFoundException: Could not load file or assembly 'System.Web.Extensions' exception.

Possible Solution

Update the project to support .NET Standard 2.0.

Your Environment

Windows 10, Visual Studio Code, dotnet core SDK 2.0.0, dotnet core 2.0.0.

@aslakhellesoy
Copy link
Contributor

This is mostly done in #174 I think

@rafaelromao
Copy link
Author

Looks like it will be fixed after this PR, but something went wrong in the build, although it passed. The version number was not upgraded and the nuget package was not published. https://ci.appveyor.com/project/aslakhellesoy/gherkin

@SabotageAndi
Copy link
Contributor

No idea why AppVeyor does not find the nuget package and uploads it.

@SabotageAndi
Copy link
Contributor

Ok, after some small changes in cucumber/gherkin-dotnet#10, the build finds the nuget package and creates a correct looking version number for it.

@aslakhellesoy
Copy link
Contributor

I believe this is fixed now. Let me know if I got it wrong.

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants