Improve rake task report on failure

[avakarev]

It will clean up output from rake's "rake aborted!" reports on failures.
Failure in this case when sh method got exit status != 0

Before:

$:> rake
/Users/avakarev/.rvm/rubies/ruby-1.9.3-p392/bin/ruby -S bundle exec cucumber --format pretty
Feature: List
  In order to be informed how many there are items
  I want to be able to see all of those items as a list

  Scenario: List an items       # features/list.feature:5
    Given I am on the home page # features/step_definitions/web_steps.rb:1
      undefined local variable or method `go' for #<Object:0x007fef1510b240> (NameError)
      ./features/step_definitions/web_steps.rb:4:in `/^I am on the home page$/'
      features/list.feature:6:in `Given I am on the home page'
    Then I should see 4 items   # features/step_definitions/web_steps.rb:26

Failing Scenarios:
cucumber features/list.feature:5 # Scenario: List an items

1 scenario (1 failed)
2 steps (1 failed, 1 skipped)
0m1.500s
rake aborted!
Command failed with status (1): [/Users/avakarev/.rvm/rubies/ruby-1.9.3-p39...]
/Users/avakarev/.rvm/gems/ruby-1.9.3-p392/gems/cucumber-1.2.3/lib/cucumber/rake/task.rb:104:in `run'
/Users/avakarev/.rvm/gems/ruby-1.9.3-p392/gems/cucumber-1.2.3/lib/cucumber/rake/task.rb:197:in `block in define_task'
/Users/avakarev/.rvm/gems/ruby-1.9.3-p392/bin/ruby_noexec_wrapper:14:in `eval'
/Users/avakarev/.rvm/gems/ruby-1.9.3-p392/bin/ruby_noexec_wrapper:14:in `<main>'
Tasks: TOP => default => features
(See full trace by running task with --trace)

After:

$:> rake
/Users/avakarev/.rvm/rubies/ruby-1.9.3-p392/bin/ruby -S bundle exec cucumber --format pretty
Feature: List
  In order to be informed how many there are items
  I want to be able to see all of those items as a list

  Scenario: List an items       # features/list.feature:5
    Given I am on the home page # features/step_definitions/web_steps.rb:1
      undefined local variable or method `go' for #<Object:0x007faed4b0a790> (NameError)
      ./features/step_definitions/web_steps.rb:4:in `/^I am on the home page$/'
      features/list.feature:6:in `Given I am on the home page'
    Then I should see 4 items   # features/step_definitions/web_steps.rb:26

Failing Scenarios:
cucumber features/list.feature:5 # Scenario: List an items

1 scenario (1 failed)
2 steps (1 failed, 1 skipped)
0m1.494s

[os97673]

Could you please add a test for this (so nobody breaks it in future)

[mattwynne]

I echo Oleg's request for a test.

Can I just confirm (because I'm too lazy to check) that the rake task will still return non-zero exit status if the task fails? It would be useful if such a test proved that.

[avakarev]

Thank you guys for your feedback.

@mattwynne
You are right. There is should be

exit res.exitstatus

in the block given to rake's sh.

So, PR is not finished yet.
I will add some changes and all the tests as soon as I will have some spare time.

[os97673]

@avakarev please let us know when the PR will be ready for review

[mattwynne]

Oleg, you're not asking him for an estimate are you? ;)

[os97673]

Estimation? What a nice word, what does it mean? ;)
What I was really asking is to notify us AFTER the PR will be ready for review, so we wouldn't miss this.
(note to @os97673: need to proof-read all messages for possible incorrect interpretations :)

[avakarev]

Here we go.
Please, review my PR.

[mattwynne]

I don't think we need this comment. The git logs will point us to your commit messages and tell us why the code looks the way it does.

[mattwynne]

Thanks @avakarev! I've added a few minor review comments.

@os97673 I was surprised to see the tests implemented as RSpec rather than Cucumber features. WDYT about that?

[avakarev]

@mattwynne Thanks for your fast feedback. I've just noticed that Travis failed on ruby 1.8.7 and jruby suits. My fault regarding 1.8.7: there is no open3#popen2e. Trying to figure out what's wrong with jruby.

[mattwynne]

On 21 Mar 2013, at 21:49, Andrey Vakarev [email protected] wrote:

@mattwynne Thanks for your fast feedback. I've just noticed that Travis failed on ruby 1.8.7 and jruby suits. My fault regarding 1.8.7: there is no open3#popen2e. Trying to figure out what's wrong with jruby.

One alternative might be to use a feature for the tests instead. Aruba has a nice cross-platform API for testing console apps. Have a look at a couple of the other features and you should get the idea.

[os97673]

@os97673 I was surprised to see the tests implemented as RSpec rather than Cucumber features. WDYT about that?

@mattwynne I think this is because there is "rake" in spec name ;)
@avakarev is it possible to rewrite the test with cucumber. As far as I can see our specs do not execute cucumber and I think it would be better to keep all real cucumber's execution in our features. Also I think we have all support code you need there.

[avakarev]

Yes. I will move tests to Cucumber's feature. And make sure that jruby works before committing :-)

[avakarev]

Could you guys please review my last changes?
At the end, I'd like not to merge all my obsolete commits.
Maybe other PR with squash?

[mattwynne]

Great!

Don't worry about the old commits, it's cool.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.