Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario Outlines with no Examples tables should behave gracefully #438

Closed
mattwynne opened this issue Apr 22, 2013 · 6 comments
Closed
Milestone

Comments

@mattwynne
Copy link
Member

First reported in #426. If we have a Scenario Outline but no Examples tables, we'll fail in an ugly fashion.

What is the correct behaviour here? Should we:

  1. raise an exception as we parse the Gherkin
  2. issue a warning as we parse the gherkin, then ignore the empty scenario outline
  3. silently ignore the empty scenario outline
  4. something else

I don't really understand why you'd want a scenario outline in your gherkin if it doesn't have any examples, so (1) seems like the right option to me. What do other people think?

@sauy7
Copy link

sauy7 commented Apr 22, 2013

I agree with 1. I had a case running against 1.0.6 where 3 seemed to be occurring.

@jarl-dk
Copy link
Member

jarl-dk commented Apr 22, 2013

I vote for (1) as well...

@tooky
Copy link
Member

tooky commented Apr 22, 2013

I'd be happy with 1 or 2.

@mattwynne
Copy link
Member Author

Replaced by PR #439. @tooky if you use the hub command-line wrapper for git you can transform an existing issue into a PR.

@tooky
Copy link
Member

tooky commented Apr 22, 2013

On Monday, 22 April 2013 at 15:37, Matt Wynne wrote:

@tooky (https://github.com/tooky) if you use the hub command-line wrapper for git you can transform an existing issue into a PR.

That sounds like a neat trick - thanks @mattwynne.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants