Default require path to features unless specified explicitly. #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general there seem to be some weird dependencies (or lack there of) between configuration options and information in `Cucumber::Cli::Configuration#feature_files` that could probably be clarified with a little refactoring. One example that this feature exposed directly is that `Cucumber::Cli::Configuration#feature_files` does not depend on `Cucumber::Cli::Configuration#feature_dirs` though their names certainly imply dependence. I had deleted `Cucumber::Cli::Configuration#feature_dirs` to eliminate the confusion, but added it back in when I realized it was used in `features/docs/post_configuration_hook.feature`
tooky
added a commit
that referenced
this pull request
Apr 30, 2015
Default require path to features unless specified explicitly.
|
Thanks for the contribution! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general there seem to be some weird dependencies (or lack there of) between
configuration options and information in
Cucumber::Cli::Configuration#feature_filesthat could probably be clarified with a little refactoring.
One example that this feature exposed directly is that
Cucumber::Cli::Configuration#feature_filesdoes notdepend on
Cucumber::Cli::Configuration#feature_dirsthough their namescertainly imply dependence.
I had deleted
Cucumber::Cli::Configuration#feature_dirsto eliminatethe confusion, but added it back in when I realized it was used in
features/docs/post_configuration_hook.feature.I took a stab at re-architecting the configuration code awhile back, but got mired and gave up. Just realized I never submitted this pull request.
Looks like there's plans to give the configuration some attention for 2.1, but maybe this is still a useful step.