Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python does not keep version in pyproject.toml #289

Closed
mpkorstanje opened this issue Sep 27, 2024 · 3 comments
Closed

Python does not keep version in pyproject.toml #289

mpkorstanje opened this issue Sep 27, 2024 · 3 comments
Assignees

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Sep 27, 2024

🤔 What's the problem you've observed?

Releases are made with a script. This is necessary because nobody can remember the intricacies and conflicting requirements of releasing (currently) 13 different languages.

So for the sake of the sanity of everyone involved in the release there should be exactly one conventional location for every python project in the Cucumber org to keep its version.

Currently the preferred place is directly in pyproject.toml.

For Gherkin currently the version is kept in setup.py.

version="29.0.0",

✨ Do you have a proposal for making it better?

Keep the version in pyproject.toml.

📚 Any additional context?

I am open to better ways of doing this, but then I'd like to see a set of merge requests apply that change to all repositories at once.

So for the short term it I'd be best to use pyproject.toml.

@youtux
Copy link
Contributor

youtux commented Sep 28, 2024

Done in #290

@jsa34
Copy link
Contributor

jsa34 commented Oct 4, 2024

Resolved in commit 24296c1

@jsa34 jsa34 closed this as completed Oct 4, 2024
@mpkorstanje
Copy link
Contributor Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants