Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions for automation #222

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

jtuttle
Copy link
Member

@jtuttle jtuttle commented Jul 21, 2021

Releases are not automatically created when a tag is pushed. This commit updates
the release instructions to take this into account.

Releases are not automatically created when a tag is pushed. This commit updates
the release instructions to take this into account.
@jtuttle jtuttle requested a review from a team as a code owner July 21, 2021 19:11
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Approved, but had a quick (curiosity, mainly) question on the highlighting of lines 4-6 in the summon.rb file.

using the file `dist/goreleaser/summon.rb`.

- [ ] In [`cyberark/homebrew-tools`](https://github.com/cyberark/homebrew-tools)
repo, create a PR to update the [`summon.rb` formula](https://github.com/cyberark/homebrew-tools/blob/main/summon.rb#L4-L6)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to highlight only lines 4-6, and not the entire file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intended, those lines were already highlighted in the previous version. I'll just leave it for now.

Copy link
Contributor

@imheresamir imheresamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jtuttle jtuttle merged commit a9d2020 into main Jul 21, 2021
@jtuttle jtuttle deleted the fix-release-instructs branch July 21, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants