Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Icon Defaults to GTK #269

Open
blobotic opened this issue Aug 30, 2021 · 2 comments
Open

Windows Icon Defaults to GTK #269

blobotic opened this issue Aug 30, 2021 · 2 comments

Comments

@blobotic
Copy link

On Windows 10, building the examples with MSYS2 (following the steps under "Windows (MinGW + Gtk)" in the "Setup and Installation" documentation), apps are initialized with the default GTK icon rather than no icon, which I presume to be unintended behavior.

Screenshots:
In the title bar (top left corner):
image
In the Windows taskbar:
image

@redtide
Copy link
Contributor

redtide commented Aug 30, 2021

Maybe it's just GTK working that way on Windows? Could you try to build and test #266 and see if it could solve the issue?

@redtide
Copy link
Contributor

redtide commented Sep 29, 2021

OK, I think this is not an issue at all because if you run the gtk3-demo.exe appears with the same GTK icon, so I suppose it's a generic replacement icon instead of the classic terminal/console icon (though this is a bit confusing to me because on Linux the GTK2 demo has the GTK icon, the GTK3 demo not, unlike on Windows).

I edited the above pull request to use also a dedicated app icon when the user sets the ELEMENTS_APP_ICON CMake variable, otherwise the Cycfi logo as default instead. Please let us know if this solution is acceptable, or if you have some suggestion if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants