-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artist_port text editor issue with 'f' character #278
Comments
I also noticed that |
I don't have time to investigate right now, but if you can dig deeper (e.g. set up break points and see where it leads to), that would be great! PS> All the more reason to delegate this task to another (preferably native) library. |
The overflow seems to happen on master branch as well. About the 'f' character, I'm still trying to figure out |
As a reminder, "f" characters are only displayed if impair number of f are typed. F characters :
Not F characters :
It appears that the flow loop doesn't go to the last index when user typed a sequence of 'f'.
|
Nice hunting! I suspected something like this. I thought it might have something to do with F-ligatures: https://creativepro.com/typetalk-the-ins-and-outs-of-f-ligatures/ |
It's good if I can resolve this issue, though, for correctness. |
Same bug for succession of 'f' and 'i' chars. So that may indeed be related to ligatures ! |
Indeed! |
BTW, do you mind filing another issue for the overflow issue? |
void hb_buffer::shape(hb_font const& font)
{
hb_feature_t userfeatures[1];
userfeatures[0].tag = HB_TAG('l','i','g','a');
userfeatures[0].value = 0;
userfeatures[0].start = HB_FEATURE_GLOBAL_START;
userfeatures[0].end = HB_FEATURE_GLOBAL_END;
hb_shape(font.get(), _buffer.get(), userfeatures, 1);
} Confirmed it has to do with ligatures. |
So, the error occurs with OpenSans and DejaVu fonts, but not with Roboto it seems. |
Funny bug this time 😄
Artist port branch, in the text_and_icons example :
write a 'f' in a text editor, all fine.
write a second one, it disappears.
write a third one, it re appears
write a fourth one, it disappears
... etc
It seems to be only with the 'f' character
The text was updated successfully, but these errors were encountered: