From 2505de933d2c38e680be5b752b214b762df4bd9e Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Wed, 23 Oct 2024 14:59:58 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> --- changes.d/6261.feat.md | 1 + changes.d/6354.feat.md | 1 - tests/integration/scripts/test_validate_reinstall.py | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 changes.d/6261.feat.md delete mode 100644 changes.d/6354.feat.md diff --git a/changes.d/6261.feat.md b/changes.d/6261.feat.md new file mode 100644 index 00000000000..46d135919fd --- /dev/null +++ b/changes.d/6261.feat.md @@ -0,0 +1 @@ +Allow a workflow to be restarted by `cylc vr` even if there are no changes to reinstall. diff --git a/changes.d/6354.feat.md b/changes.d/6354.feat.md deleted file mode 100644 index b150a0afb7f..00000000000 --- a/changes.d/6354.feat.md +++ /dev/null @@ -1 +0,0 @@ -Fix an issue that could cause clock-expired tasks to be erroneously retried if "execution retry delays" were configured. diff --git a/tests/integration/scripts/test_validate_reinstall.py b/tests/integration/scripts/test_validate_reinstall.py index 5ecbf3edadf..e74e28cb6ac 100644 --- a/tests/integration/scripts/test_validate_reinstall.py +++ b/tests/integration/scripts/test_validate_reinstall.py @@ -37,14 +37,14 @@ async def test_prompt_for_running_workflow_with_no_changes( See: https://github.com/cylc/cylc-flow/issues/6261 - We hope to get users into the habbit of "cylc vip" to create a new run, + We hope to get users into the habit of "cylc vip" to create a new run, and "cylc vr" to contine an old one (picking up any new changes in the process). This works fine, unless there are no changes to reinstall, in which case the "cylc vr" command exits (nothing to do). - The "nothing to reinstall" situation can be interpretted two ways: + The "nothing to reinstall" situation can be interpreted two ways: 1. Unexpected error, the user expected there to be something to reinstall, but there wasn't. E.g, they forgot to press save. 2. Unexpected annoyance, I wanted to restart the workflow, just do it.