Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc dump still showing more than just n=0 tasks #6366

Open
hjoliver opened this issue Sep 11, 2024 · 1 comment
Open

cylc dump still showing more than just n=0 tasks #6366

hjoliver opened this issue Sep 11, 2024 · 1 comment
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Sep 11, 2024

Test case:

[scheduling]
    [[graph]]
        R1 = "foo => bar"
[runtime]
    [[foo]]
        script = false
    [[bar]]

When this stalls with 1/foo failed, manually trigger 1/bar - which will succeed and leave the task pool.

After this, cylc dump shows 1/bar as present in n=0 even though it is not there (it will be at n=1 relative to the incomplete failed 1/foo):

$ cylc dump -t --flows bug          
bar, 1, succeeded, not-held, not-queued, not-runahead, [1]  # <------ 
foo, 1, failed, not-held, not-queued, not-runahead, [1]

I can confirm that 1/bar is not actually in the pool by trying to remove it:

INFO - Command "remove_tasks" received. ID=49c118ba-2252-4eaa-b4d0-326916a39e57
    remove_tasks(tasks=['1/bar'])
WARNING - No active tasks matching: 1/bar  # <-------
@hjoliver hjoliver added the bug Something is wrong :( label Sep 11, 2024
@hjoliver hjoliver added this to the 8.3.x milestone Sep 11, 2024
@oliver-sanders
Copy link
Member

oliver-sanders commented Sep 11, 2024

Reproduced. The cylc dump command is querying tasks using the graphDepth argument to filter by n-window.

The graphDepth in the data store is incorrect. This query:

{
  workflows {
    taskProxies {
      id
      graphDepth
    }
  }
}

Returns:

{
  "data": {
    "workflows": [
      {
        "taskProxies": []
      },
      {
        "taskProxies": [
          {
            "id": "~me/tmp.yHSiyZYCNF/run1//1/foo",
            "graphDepth": 0
          },
          {
            "id": "~me/tmp.yHSiyZYCNF/run1//1/bar",
            "graphDepth": 0
          }
        ]
      }
    ]
  }
}

If I reload the workflow, then the graphDepth is correctly changed to 1.

          {
            "id": "~me/tmp.yHSiyZYCNF/run1//1/bar",
            "graphDepth": 1
          }

So this is likely a missing data-store call? Or the data is going in, but the update isn't going out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

3 participants