Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

what do do with special areas? #45

Open
TSchiefer opened this issue Mar 30, 2021 · 1 comment
Open

what do do with special areas? #45

TSchiefer opened this issue Mar 30, 2021 · 1 comment
Milestone
0.3.0

Comments

@TSchiefer
Copy link
Member

As it turns out, our mapping tables include the only land-area which is not part of a municipality ("Staatswald Galm", BFSNr: 2391) and five "Kommunanzen", which belong to more than one municipality. Two of the latter still exist.
I don't think that's necessarily wrong, it's just something to be aware of.
Possibly we should mention it in the documentation.

E.g. in the downloaded BFS data (load_bfs_mun_list()) these areas do not appear among the municipalities.

More details in https://github.com/cynkra/munch/blob/f-31-tests/tests/testthat/test-external-consistency.R
@krlmlr
Copy link
Collaborator

krlmlr commented Mar 30, 2021

The tests are fine, let's postpone for now. It shouldn't be a problem if the mapping table contains too many items.

@TSchiefer TSchiefer added this to the 0.3.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@krlmlr @TSchiefer