Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second arg from cy.wrap #496

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Remove second arg from cy.wrap #496

merged 2 commits into from
Jun 10, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jun 3, 2021

Address cypress-io/cypress#16785

cy.wrap() accepts a subject and options arguments - not a string as a second arg.

Remove erroneous second string arg from example.

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ Deploy Preview for cypress-example-kitchensink ready!

🔨 Explore the source changes: 232afc5

🔍 Inspect the deploy log: https://app.netlify.com/sites/cypress-example-kitchensink/deploys/60c16021f0ef4f00078df536

😎 Browse the preview: https://deploy-preview-496--cypress-example-kitchensink.netlify.app

@cypress
Copy link

cypress bot commented Jun 3, 2021



Test summary

120 0 0 0


Run details

Project cypress-example-kitchensink
Status Passed
Commit 232afc5
Started Jun 10, 2021 1:28 AM
Ended Jun 10, 2021 1:32 AM
Duration 04:10 💡
OS Windows 10.0.17763
Browser Firefox 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jun 3, 2021



Test summary

240 0 0 0


Run details

Project cypress-example-kitchensink
Status Passed
Commit dcb5e39 ℹ️
Started Jun 10, 2021 12:44 AM
Ended Jun 10, 2021 12:52 AM
Duration 07:33 💡
OS Linux Ubuntu - 16.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super

@@ -43,8 +43,7 @@ context('Files', () => {
.to.deep.equal(requiredExample)

// or use "cy.wrap" and "should('deep.equal', ...)" assertion
// @ts-ignore

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is still valid, it shouldn't be removed this.example resolves to any due to the mocha context not being extended.

@panzarino panzarino merged commit 1572887 into master Jun 10, 2021
@panzarino
Copy link
Contributor

Since this was approved and working, I went ahead and merged since I needed to trigger semantic-release

@bahmutov
Copy link
Contributor

🎉 This PR is included in version 1.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emilyrohrbough emilyrohrbough deleted the remove-second-arg-wrap branch March 30, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants