-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove second arg from cy.wrap #496
Conversation
✔️ Deploy Preview for cypress-example-kitchensink ready! 🔨 Explore the source changes: 232afc5 🔍 Inspect the deploy log: https://app.netlify.com/sites/cypress-example-kitchensink/deploys/60c16021f0ef4f00078df536 😎 Browse the preview: https://deploy-preview-496--cypress-example-kitchensink.netlify.app |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super
@@ -43,8 +43,7 @@ context('Files', () => { | |||
.to.deep.equal(requiredExample) | |||
|
|||
// or use "cy.wrap" and "should('deep.equal', ...)" assertion | |||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is still valid, it shouldn't be removed this.example resolves to any due to the mocha context not being extended.
Since this was approved and working, I went ahead and merged since I needed to trigger semantic-release |
🎉 This PR is included in version 1.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Address cypress-io/cypress#16785
cy.wrap()
accepts asubject
andoptions
arguments - not a string as a second arg.Remove erroneous second string arg from example.