Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI runs Windows tests under unsupported Node.js 14 - renovate fails #721

Closed
MikeMcC399 opened this issue Aug 14, 2023 · 5 comments · Fixed by #739
Closed

CircleCI runs Windows tests under unsupported Node.js 14 - renovate fails #721

MikeMcC399 opened this issue Aug 14, 2023 · 5 comments · Fixed by #739
Labels

Comments

@MikeMcC399
Copy link
Collaborator

Issue

Windows tests in CircleCI specified through .circleci/config.yml use the image windows-server-2019-vs2019:stable with the now unsupported Node.js 14.17.5 version.

  1. renovate's PR chore(deps): update dependency to version 🌟 #720 fails in CircleCI Windows with npm ERR! Cannot read property 'npm-run-all' of undefined. This PR is attempting to bump the lockfileVersion in package-lock.json from 2 to 3. npm lockfileVersion 3 is used by npm v9, however it is only backwards compatible to npm v7. Node.js 14.17.5 is configured with the earlier version npm 6.14.14 thus causing a compatibility issue.
  2. Node.js 14 entered end-of-life on April 30, 2023.
  3. .node-version specifies Node.js 18 as the required version for this repo.

Suggestion

Update .circleci/config.yml to run under Node.js 18 (currently the LTS version) for the Windows tests.

@MikeMcC399
Copy link
Collaborator Author

I don't have the experience with CircleCI to confidently attempt this change, so I need to leave it to somebody else with the right skills.

I noticed also that an older version of Windows Server is being used. Would it be a good time to upgrade this as well?

image: "windows-server-2019-vs2019:stable"

@nagash77
Copy link
Contributor

Hi @MikeMcC399 , yeah it looks like we need to upgrade the image as you suggested. Thanks for opening this issue so we can track this work and hopefully find some time to do this.

@MikeMcC399
Copy link
Collaborator Author

@AtofStryker

Could you perhaps look at this issue also as part of your updating work for Node.js 18? It needs some tweaking on CircleCI for Windows.

@AtofStryker
Copy link
Contributor

@MikeMcC399 #739 should get us to Node 20

@AtofStryker AtofStryker linked a pull request Sep 11, 2023 that will close this issue
@cypress-app-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants