Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update engines to disallow node.js 21 #844

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented May 31, 2024

BREAKING CHANGE:

This PR updates the engines section in package.json to

  "engines": {
    "node": "^18.0.0 || ^20.0.0 || >=22.0.0"
  }

Background

package.json

currently lists

  "engines": {
    "node": "^18.0.0 || >=20.0.0"
  }

as supported Node.js versions. This is no longer in line with the Node.js release schedule:

  • Node.js 21 passed into end-of-life status on Jun 1, 2024.

Verification

mkdir update-test
cd update-test
git init
npm init -y
npm install https://github.com/MikeMcC399/cypress-example-kitchensink#update/engines-node-21-eol

Check npm ci for following Node.js versions. Disallowed Node.js versions should produce a warning.

Node.js Result
v17.9.1 EBADENGINE
v18.20.3 success
v19.9.0 EBADENGINE
v20.14.0 success
v21.7.3 EBADENGINE
v22.2.0 success

BREAKING CHANGE:
Support Node.js 18.x, 20.x, 22.x and later
@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 31, 2024 16:25
@jennifer-shehane jennifer-shehane merged commit b9de7b7 into cypress-io:master Jun 3, 2024
14 checks passed
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the update/engines-node-21-eol branch June 3, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants