From a16edd56903e32da598d07c0c8d0e835d060396a Mon Sep 17 00:00:00 2001 From: Cacie Prins Date: Mon, 1 Jul 2024 12:39:03 -0400 Subject: [PATCH] chore: move frontend-shared from a dev dependency to a runtime dependency in launchpad package.json (#29783) * build: move frontend-shared from a dev dependency to a runtime dependency in launchpad package.json * bmp * add darwin workflow * move frontend-shared back to dev dependency in launchpad, declare as nx implicit dep --- .circleci/cache-version.txt | 2 +- .circleci/workflows.yml | 3 ++- packages/launchpad/package.json | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.circleci/cache-version.txt b/.circleci/cache-version.txt index 98d210307bac..c7d74b8a00e2 100644 --- a/.circleci/cache-version.txt +++ b/.circleci/cache-version.txt @@ -1,3 +1,3 @@ # Bump this version to force CI to re-create the cache from scratch. -06-07-24 +07-01-24 diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml index 7e6daf090613..b85f2225dbad 100644 --- a/.circleci/workflows.yml +++ b/.circleci/workflows.yml @@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters - /^release\/\d+\.\d+\.\d+$/ # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - 'update-v8-snapshot-cache-on-develop' - - 'ignore-chrom-prefs' + - 'investigate/darwin-ci-build-order' - 'publish-binary' - 'angular-signals-ct-harness' @@ -44,6 +44,7 @@ macWorkflowFilters: &darwin-workflow-filters # use the following branch as well to ensure that v8 snapshot cache updates are fully tested - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ] - equal: [ 'angular-signals-ct-harness', << pipeline.git.branch >> ] + - equal: [ 'investigate/darwin-ci-build-order', << pipeline.git.branch >> ] - matches: pattern: /^release\/\d+\.\d+\.\d+$/ value: << pipeline.git.branch >> diff --git a/packages/launchpad/package.json b/packages/launchpad/package.json index 1eb057237309..407126c6be12 100644 --- a/packages/launchpad/package.json +++ b/packages/launchpad/package.json @@ -75,7 +75,8 @@ ], "nx": { "implicitDependencies": [ - "@packages/graphql" + "@packages/graphql", + "@packages/frontend-shared" ] } }