Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite.config.ts not working with Vite 3 (internal monorepo) #22945

Open
lmiller1990 opened this issue Jul 26, 2022 · 0 comments
Open

vite.config.ts not working with Vite 3 (internal monorepo) #22945

lmiller1990 opened this issue Jul 26, 2022 · 0 comments
Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug

Comments

@lmiller1990
Copy link
Contributor

Current behavior

In #22915 we updated to Vite 3. For unknown reasons, I had to change vite.config.ts to vite.config.mjs to make it work. I can't find anything in their release notes about this, though.

I suspect mts will also work, once we update our TypeScript version to 4.7. 4.7 notes on mjs and mts.

Desired behavior

I want to use strongly typed vite.config.

Test code to reproduce

  • Change vite.config.mjs to vite.config.ts in packages/{app,launchpad,frontend-shared} (once feat: update to Vite 3 #22915 is merged)
  • Run yarn build-prod-ui in packages/{app,launchpad}
  • Error

Cypress Version

develop

Other

This only impacts the monorepo, vite.config.ts seems fine for users, I guess it's an issue in our monorepo only, possibly due to old TypeScript version, or some other dependency.

@github-actions github-actions bot added the stale no activity on this issue for a long period label Apr 13, 2023
@nagash77 nagash77 added routed-to-ct and removed stale no activity on this issue for a long period labels Apr 13, 2023
@cypress-io cypress-io deleted a comment from github-actions bot Apr 13, 2023
@nagash77 nagash77 added CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed routed-to-ct labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: bug
Projects
None yet
Development

No branches or pull requests

4 participants