Add SOCKS proxy support #195
Conversation
|
I've managed to test your changes in practice. It works according to the instruction from the Redshift provider. Note that the |
|
For those interested, I have pushed a version of the provider with this patch at https://registry.terraform.io/providers/Tenzer/postgresql/1.15.0-proxy. It should make it easier to test out. I don't intend to maintain a fork and would instead hope this feature could be incorporated here. |
There was a problem hiding this comment.
Hello,
Thanks for the PR, I allowed myself to merge master as it fixes failing golangci-lint.
I don't know by heart the interface for sql/pq but I trust you and the tests 👍
Could you just add in the usage documentation how to use it (more to show that it's possible)?
Thanks in advance.
This copies the implentation from the Redshift provider: brainly/terraform-provider-redshift#19. It allows users to proxy the requests to the database server through a SOCKS proxy, in case the database server cannot be reached directly.
As part of this I found out the format of the values in the environment variables isn't standardized, so there only place we potentially could link to about the format of the values would be the source code for `golang.org/x/net/proxy`. I thought that was a bit much, so I've instead included a simple example instead.
Tenzer
force-pushed
the
add-proxy-support
branch
from
6b1921c
to
48c30ca
Compare
|
@cyrilgdn I've added a couple of lines about it to that document now. I rebased the branch on top of My workplace has been using this patch since I made the PR, and it's working for us. |
|
Thanks again for your work 👏 |
|
FYI, this has just been released in v1.16.0 |
This copies the implementation from the Redshift provider: brainly/terraform-provider-redshift#19.
It allows users to proxy the requests to the database server through a SOCKS proxy, in case the database server cannot be reached directly.
I have only added it for the "postgres" as it seems to be more cumbersome to do with the AWS and GCP specific drivers, since they wrap the low-level PostgreSQL driver multiple times.
I'd like feedback on if this would be a welcome addition. If so, I'll add some documentation about how to configure this (like the Redshift provider has).
Relates to #184.