Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large test data cases to help detect non-deterministic challenges #193

Closed
d33bs opened this issue Apr 18, 2024 · 0 comments · Fixed by #212
Closed

Add large test data cases to help detect non-deterministic challenges #193

d33bs opened this issue Apr 18, 2024 · 0 comments · Fixed by #212
Labels
enhancement New feature or request

Comments

@d33bs
Copy link
Member

d33bs commented Apr 18, 2024

Probably best served by a different PR, but I'm wondering if it is worth adding a test that ensures, in a large enough dataset, that there are no duplicate rows and all expected rows are present.

Originally posted by @gwaybio in #182 (review)

This could take place with a synthetic dataset which is created through duplication of source data rows with minor variations. It could also reference a remote dataset.

Likely useful to add a Pytest marker indicating the nature of the test as "large" to allow development to skip the test by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant