Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromectrl: a new timer for message loop processing is created for each ChromeWindow instance #129

Closed
GoogleCodeExporter opened this issue Aug 28, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

There should be only one global timer running. In the wxpython.py example the 
timer is created and destroyed in wx.App. But in chromectrl it is created for 
each chrome window. Creating multiple timers that call CefMessageLoopWork 
simultaneously might result in performance penalties and an undefined behavior.

Original issue reported on code.google.com by [email protected] on 30 Jul 2014 at 8:11

@GoogleCodeExporter
Copy link
Author

Chromectrl creates a timer with given ID. Does calling wx.Timer() multiple 
times given the same ID result only in one timer running? The timer ID is 
currently = 1. What if other part of app assigns the same id? Should it be 
unique?

Original comment by [email protected] on 30 Jul 2014 at 8:24

@GoogleCodeExporter
Copy link
Author

Answering question from the post above. The timer is associated with "self" 
which is ChromeWindow, so the ID uniqueness is not a problem. But still it 
creates multiple timers for multiple ChromeWindow instances.

Original comment by [email protected] on 30 Jul 2014 at 8:27

@GoogleCodeExporter
Copy link
Author

Fixed in revision e592db916887.

Original comment by [email protected] on 30 Jul 2014 at 9:44

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Project will move to Github. Find this issue at the new address (soon): 
https://github.com/cztomczak/cefpython/issues/129

Original comment by [email protected] on 24 Aug 2015 at 6:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant