Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LifespanHandler #139

Closed
GoogleCodeExporter opened this issue Aug 28, 2015 · 5 comments
Closed

Implement LifespanHandler #139

GoogleCodeExporter opened this issue Aug 28, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

By now, it is partially "Not yet ported to cefpython."

I am providing a patch, which is based on revision c1260fb985e6

The Patch additionally adds support for windowInfo and browserSupport arguments 
of OnBeforePopup.

Tested only on Linux 64.

Original issue reported on code.google.com by [email protected] on 24 Sep 2014 at 4:22

Attachments:

@GoogleCodeExporter
Copy link
Author

Thanks for the patch. In OnBeforePopup it should be allowed for browserSettings 
and windowInfo to be optional/empty lists, so that it is backwards compatible.

Original comment by [email protected] on 24 Sep 2014 at 7:03

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

OK, here's the updated patch.

Again, tested only on Linux64.

Original comment by [email protected] on 28 Sep 2014 at 2:08

Attachments:

@GoogleCodeExporter
Copy link
Author

Fixed in revision 6b141a8f54b4. The following fixes were applied to the patch:
 * Added usage example to wxpython.py. Please include tests next time.
 * LifespanHandler_OnAfterCreated returned cpp_bool instead of void
 * Callbacks that return cpp_bool should cast its value using bool() otherwise warnings appear during compilation
 * When using comparison operators please put the const value on the right, so that it is consistent with existing code base
 * OnAfterCreated callback cannot be included in allowedClientCallbacks list in SetClientCallback_CEF3. It is called during browser creation, thus will only work if set as a global client callback using cefpython.`SetGlobalClientCallback()`.

Original comment by [email protected] on 14 Oct 2014 at 8:50

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Project will move to Github. Find this issue at the new address (soon): 
https://github.com/cztomczak/cefpython/issues/139

Original comment by [email protected] on 24 Aug 2015 at 6:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant