Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug flag not set in C++ code for the Browser process #98

Closed
GoogleCodeExporter opened this issue Aug 28, 2015 · 3 comments
Closed

Debug flag not set in C++ code for the Browser process #98

GoogleCodeExporter opened this issue Aug 28, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

In cefpython_app.cpp the g_debug variable is set only for the Render process in 
CefPythonApp::OnRenderThreadCreated(). This flag also needs to be set when 
CefPythonApp class is instantiated in the Browser process.

Original issue reported on code.google.com by [email protected] on 18 Dec 2013 at 1:42

@GoogleCodeExporter
Copy link
Author

When g_debug is set in the browser proces, it won't be required to call 
BrowserProcessHandler_OnRenderProcessThreadCreated(). It's better get rid of 
this call as it might cause a deadlock 
(CefBrowserProcessHandler::OnRenderProcessThreadCreated called on the IO 
thread, then it calls Python on the UI thread). Deadlock issue reported by 
Michael Goffioul when porting CEF to Linux/Aura.

Original comment by [email protected] on 8 Jan 2014 at 9:40

@GoogleCodeExporter
Copy link
Author

Fixed in revision fd0ed30fb387.

Original comment by [email protected] on 15 Jan 2014 at 9:39

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Project will move to Github. Find this issue at the new address (soon): 
https://github.com/cztomczak/cefpython/issues/98

Original comment by [email protected] on 24 Aug 2015 at 6:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant