Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to change the flags in the installed browser instance, flags are hard coded in C++ #334

Open
didlie opened this issue Jul 25, 2024 · 0 comments

Comments

@didlie
Copy link

didlie commented Jul 25, 2024

This issue is related to the settings of the in-app browser instance set with hard-coded flags.

No settings adjustment to enable auto-accept for location functions, or enable to pup-up user dialogue to accept location. There is also no way to adjust the shell flags used when the browser is opened in the application.

Suggestions: 1) change the format of the settings JSON with all possible settings to allow user switching, (eg. true/false). 2) Change the hard-coded flags to a scheme that opens the browser with a CL where flags are adjustable in a .config file.

Browser-instance log looks like this: - 07:16:05.078 DEBUG: Command line string for the renderer process: "C:\phpdesktop\phpdesktop-chrome.exe" --type=renderer --no-sandbox --primordial-pipe-token=DF260D665200B20F0F1F18B0EA61EE51 --lang=en-US --lang=en-US --log-file="C:\phpdesktop\debug.log" --enable-pinch --device-scale-factor=1 --num-raster-threads=4 --enable-main-frame-before-activation --content-image-texture-target=0,0,3553;0,1,3553;0,2,3553;0,3,3553;0,4,3553;0,5,3553;0,6,3553;0,7,3553;0,8,3553;0,9,3553;0,10,3553;0,11,3553;0,12,3553;0,13,3553;0,14,3553;0,15,3553;1,0,3553;1,1,3553;1,2,3553;1,3,3553;1,4,3553;1,5,3553;1,6,3553;1,7,3553;1,8,3553;1,9,3553;1,10,3553;1,11,3553;1,12,3553;1,13,3553;1,14,3553;1,15,3553;2,0,3553;2,1,3553;2,2,3553;2,3,3553;2,4,3553;2,5,3553;2,6,3553;2,7,3553;2,8,3553;2,9,3553;2,10,3553;2,11,3553;2,12,3553;2,13,3553;2,14,3553;2,15,3553;3,0,3553;3,1,3553;3,2,3553;3,3,3553;3,4,3553;3,5,3553;3,6,3553;3,7,3553;3,8,3553;3,9,3553;3,10,3553;3,11,3553;3,12,3553;3,13,3553;3,14,3553;3,15,3553 --service-request-channel-token=DF260D665200B20F0F1F18B0EA61EE51 --renderer-client-id=3 --mojo-platform-channel-handle=2440 /prefetch:1

? if hard coded, where is there room for language adjustment
? no way to add user-interface flags

  1. should also be a list of flags (complete with description)

Questions should be asked on the forum:
https://groups.google.com/d/forum/phpdesktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant