Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling soft auditors to vet v1.0.1 on npm #1

Open
d13co opened this issue Oct 4, 2023 · 3 comments
Open

Calling soft auditors to vet v1.0.1 on npm #1

d13co opened this issue Oct 4, 2023 · 3 comments

Comments

@d13co
Copy link
Owner

d13co commented Oct 4, 2023

Hi,

If you are well versed enough in Javascript to go through the code on NPM and confirm that it doesn't include anything nasty that could exfil a user's seed phrase, that would help a lot.

The package is intended to be fixed @ 1.0.0 1.0.1* version, so if you want to audit the code on npm which is immutable and drop a comment in this issue about it doing what it says on the tin/README, that would be appreciated by myself and skeptical potential users.

* 1.0.1 published after feedback below

@d13co
Copy link
Owner Author

d13co commented Oct 4, 2023

Things to check:

.js files:

  • do not do network calls
  • do not save the seed phrase anywhere

package.json:

  • only imports the algosdk package
  • does not run any custom stuff like postinstall scripts

@d13co d13co changed the title Calling soft auditors Calling soft auditors to vet v1.0.0 on npm Oct 4, 2023
@guanzo
Copy link

guanzo commented Oct 4, 2023

For more immutability I would pin the algosdk version to 1.18.1 (remove the ^). That will avoid installing future malicious versions, however unlikely but possible.

@d13co
Copy link
Owner Author

d13co commented Oct 5, 2023

Fair enough - I didn't intend to change this but why not. 1.0.1 published with fixed algosdk.
If you think the code is benign please leave a comment to this effect.
Thanks!

@d13co d13co changed the title Calling soft auditors to vet v1.0.0 on npm Calling soft auditors to vet v1.0.1 on npm Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants