use reqwest::blocking::Client with no timeout where the default 30s might not be enough #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt 30s might not be enough
CrazyByDefault
changed the title
|
hello, i do not agree with setting the timeout to 'None' for the repo. it is not a good practice to fully disable a request timeout in general. if you are running into timeouts for yourself frequently then id look into shelving this commit locally so that it works for you but a 30s timeout is plenty for 99% of scenarios. on top of that im sure bungie has a connection timeout on their end as well but we shouldnt rely on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to request::blocking::get() docs, the request will fail if the download takes longer than 30s.
this PR implements a basic
reqwest::blocking::Clientwithtimeout=Nonefor this request in particularfixes #126