Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature: annoFuse summary plot in shiny #92

Open
kgaonkar6 opened this issue Apr 20, 2021 · 1 comment
Open

Update feature: annoFuse summary plot in shiny #92

kgaonkar6 opened this issue Apr 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@kgaonkar6
Copy link
Contributor

Purpose/implementation Section

Briefly descibe the feature

I was wondering if we should allow users to provide the grouping column for plot_summary() call here:

p <- plot_summary(values$annofuse_tbl, base_size = 10)
currently it uses the default groupby <- "Sample" looks quite busy when we have a lot of samples.

Can we add groupby=gby_rf to the function call to use the reactive value from the user as we do for the recurrent plots? This would be useful when the user has subgroup columns like we had "broad_histology" to plot fusion summary and recurrent fusion/gene per subgroup which might look cleaner.

Who will complete the feature request (please add a GitHub handle here if relevant)?

@federicomarini

@kgaonkar6 kgaonkar6 added the enhancement New feature or request label Apr 20, 2021
@federicomarini
Copy link
Collaborator

I was almost sure I either did this already, or maybe I simply think I should have done it - simply because, well, it is a meaningful feature to have.

I'll look into this later and see how far I can get, maybe it is relatively simple to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants