Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddThis Smart Layers API Integration #39

Open
doylejd opened this issue Aug 20, 2015 · 3 comments
Open

AddThis Smart Layers API Integration #39

doylejd opened this issue Aug 20, 2015 · 3 comments

Comments

@doylejd
Copy link
Contributor

doylejd commented Aug 20, 2015

The Smart Layers API allows you to have more control over how AddThis functions on your website. For more information see: http://support.addthis.com/customer/portal/articles/1200473-smart-layers-api

Initial thoughts on how to do this and to discuss further with @nerdstein and @damontgomery :

  • Create a configuration entity to handle the config?
  • Allow the configuration to be attached to a route? Maybe set a default and allow specific ones to be overridden? My thought is that you will want most of your site to be consistent - but if you have promo pages you might want to allow for alternate options.
  • Could do this at the block level, but that doesn't feel right to me.

Option 2:

  • Provide a new global configuration page for site-wide settings for SmartLayersAPI.
  • Add the SmartLayersAPI config to the AddThisScriptManager and update the JS as needed
@nerdstein
Copy link
Contributor

@kylebrowning - is this a good use case for a Service?

@nerdstein
Copy link
Contributor

@doylejd - we're working on the Services D8 port that seems similar to what your describing. @kylebrowning would need to provide guidance on if this use case fits the bill

@damontgomery
Copy link
Contributor

@doylejd based on http://support.addthis.com/customer/portal/articles/1216215-what-are-smart-layers- it seems like the use case for these are different. The smart layers is the newer system for them and honestly seems a lot easier to use, but doesn't provide buttons that you can place inline with content.

Maybe smart layers makes sense as a sub module or additional module all together?

Honestly, adding addthis is not that difficult on a site by site basis. As such, I think you will get more benefit from making the functionality of this module very specific and limited. If users want to customize it, they can add the widget themselves. You sacrifice the major use case by adding all of this complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants