Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight option for "Security" Menu tab (Local task menu) #16

Open
dbjpanda opened this issue Apr 6, 2016 · 5 comments
Open

Weight option for "Security" Menu tab (Local task menu) #16

dbjpanda opened this issue Apr 6, 2016 · 5 comments

Comments

@dbjpanda
Copy link
Member

dbjpanda commented Apr 6, 2016

There should be a weight option inside Tfa configuration page for "Security" menu . So that admin can configure the weight of Security menu according to his/her wish. He/She may want to keep this menu just after "Edit" menu or may want atlast. Please suggest so that i can code accordingly.

@therealssj
Copy link
Contributor

What do you mean by security menu?

@dbjpanda
Copy link
Member Author

dbjpanda commented Apr 7, 2016

Check the Security menu (or Local task menu ) in tfa_basic.links.task.yml

@dbjpanda dbjpanda changed the title Weight option for Security menu Weight option for "Security" Menu tab (Local task menu) Apr 7, 2016
@nerdstein
Copy link
Contributor

Let me try to understand the use case better. The user story would be...

As an administrator, I want to be able to set the tab weight on an authenticated user's local tasks

Is this correct?

One concern that I have is that this is not a "global" setting. Often, this weight value will be user specific. Each user could potentially have a different set of tabs depending on their permissions.

I am curious - what happens if you remove the weight from tfa_basic.links.task.yml? Does it append at the end? It might be worth exploring that use case instead of this approach

@dbjpanda
Copy link
Member Author

dbjpanda commented Apr 7, 2016

Answer to your first question : Yes you are correct.
If we remove the weight from tfa_basic.links.task.yml, it is still working as per the admin configuration.

@nerdstein
Copy link
Contributor

OK. I think I get this better now.

The module is hardcoding the weight, which does not empower an administrator to move it at their discretion.

But, by removing the weight attribute of that link, is an administrator able to override it? Is there something in the menu system that would allow an admin to configure this? If so, we probably do not need this to be configurable. We would just remove the "weight" attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants