Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character rendering broken with varying word lengths combined with wrapping #258

Open
Lyude opened this issue Nov 8, 2020 · 7 comments
Open

Comments

@Lyude
Copy link

Lyude commented Nov 8, 2020

Describe the bug
If you have wrapping enabled in neovim-gtk (:set wrap) and you have a long string of text which contains words of varying lengths (such as the string "foo ba " repeated until wrapping starts), some of the words don't appear to actually render. Interestingly enough, the only words that don't render are ones which are shorter than the longest word in the string.

An example

Technical information (please complete the following information):

Some other info that might help:

  • Pango version: 1.47.0
  • GTK version: 3.24.23
@Lyude
Copy link
Author

Lyude commented Nov 8, 2020

Heh, moments after filing this issue I happened to notice something else: it's not just word wrapping, the problem seems to happen if there's any non-ASCII glyphs being displayed on the same line ("→foo ba foo" by itself exhibits the same issue):

Screenshot from 2020-11-08 17-06-55

@Lyude Lyude changed the title Character rendering broken with varying word lengths with wrapping enabled Character rendering broken with varying word lengths combined with non-ASCII glyphs Nov 8, 2020
@theHamsta
Copy link

theHamsta commented Nov 8, 2020

Possible duplicate of #254 . I have the same issue since updating to Ubuntu 20.10 and thus to a newer pango version. Would really love having this solved.

@Lyude Lyude changed the title Character rendering broken with varying word lengths combined with non-ASCII glyphs Character rendering broken with varying word lengths combined with wrapping Jan 24, 2021
@Lyude
Copy link
Author

Lyude commented Jan 24, 2021

Hm, ironically I had just finished teaching myself rust (I've done plenty of C programming, but rust is new to me!) and was about to start debugging this and come up with a fix, and then I noticed after updating my system today I'm not seeing the issue anymore. It looks like maybe this was a regression with pango or something? Unfortunately I'm not quite sure what updated to fix this, fwiw: I'm now on pango 1.48.0-1.fc33, gtk3 3.24.24-1.fc33.

@theHamsta btw ^

@Lyude
Copy link
Author

Lyude commented Jan 24, 2021

Ah-nevermind, just managed to reproduce it. Looking to see if I can figure out the fix for this

@theHamsta
Copy link

😄 Just recompiled with latest master of pango, and I'm also still seeing this issue.

@Lyude
Copy link
Author

Lyude commented Jan 24, 2021

Also dear neovim-gtk maintainer - if you can get to this first I'd recommend it, I'm definitely not that familiar with this codebase (and don't have a whole ton of time on my hands) so it might take me a while to figure out the problem here.

I have figured out one thing at least, which is that it was 279bd5256b17ed68d50fbaaf7df60f189de33c96 ("itemize: Work around gtk2 brokenness") in pango that caused this breakage

@theHamsta
Copy link

theHamsta commented Jan 24, 2021

Btw. I am not a maintainer. But your info may be interesting for @daa84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants