Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Best practice' ruleset isn't the 'bestest' #220

Closed
garconvacher opened this issue Feb 13, 2019 · 1 comment
Closed

'Best practice' ruleset isn't the 'bestest' #220

garconvacher opened this issue Feb 13, 2019 · 1 comment

Comments

@garconvacher
Copy link

garconvacher commented Feb 13, 2019

Hi,

This is a side effect from Epubcheck 4.2.
@mattgarrish gave a good advice about using ARIA roles properly. So I removed roles in the links inside <nav epub:type="landmarks">. Logically, ACE warns about this : Element has no ARIA role matching its epub:type

@mattgarrish
Copy link

Right, I don't believe Ace distinguishes the specialized lists defined in the navigation document, and because epubcheck isn't currently validating role usage it will introduce conflicts that will then be exposed by the new version of epubcheck.

A good start at tuning down Ace might be to ignore any use of epub:type inside of nav elements, as I believe that's where EPUB really went astray from ARIA. Whether epub:type is used on the list items or on the a tags, it's typically being used to convey what structure is at the end of the link, whereas roles change the nature of the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants