Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub-utils: xmldom-alpha is no longer maintained #330

Closed
karfau opened this issue Sep 18, 2020 · 4 comments
Closed

epub-utils: xmldom-alpha is no longer maintained #330

karfau opened this issue Sep 18, 2020 · 4 comments

Comments

@karfau
Copy link

karfau commented Sep 18, 2020

Hello, I just wanted to let you know that the package xmldom (which is from the same code base as xmldom-alpha this is being used in package.json) was not maintained for a while and that's why a new github organization took over maintainance under https://github.com/xmldom/xmldom .

While the new organization is publishing new versions to the xmldom package, there are no plans of maintaining the separate xmldom-alpha package.

The version you are using also contains a bug/regression that has been fixed and will soon be published as part of the v0.4.0 of the xmldom package.

I'm informing you about this, since this package is one of the last remaining dependents of xmldom-alpha.

@danielweck
Copy link
Member

Thank you for taking the time to let us know.

You will be pleased to hear that we migrated away from xmldom-alpha several months ago, although the change was introduced in a Git branch dedicated to the "next" version of Ace, which is still tagged as "beta" on NPM (even though it is already deployed in the Ace App GUI).

master branch:

"xmldom-alpha": "^0.1.28",

=> version 1.1.1, NPM tag "latest":

https://www.npmjs.com/package/@daisy/ace/v/latest

ace-next branch:

"xmldom": "^0.3.0",

=> version 1.2.0-beta.12, NPM tag "next":

https://www.npmjs.com/package/@daisy/ace/v/next

master branch of Ace App:

https://github.com/daisy/ace-gui/blob/269cc559898b5c6695dc98f80612644d39bd36b9/package.json#L182

@karfau
Copy link
Author

karfau commented Sep 18, 2020

Glad to hear that.
I would be fine to close this issue, but maybe you want to keep it open for transparency, so I'm leaving it as it is.

@karfau
Copy link
Author

karfau commented Mar 21, 2021

Just to let you know that all versions of xmldom-alpha (and xmldom < 0.5.0) suffer from the security issue fixed in [email protected].

We are not able to deprecate the xmldom-alpha package. Just wanted to let you know in case you want to either release an update for the old version or deprecate those old versions.

@danielweck
Copy link
Member

Closing now, as fixed in Ace "next" #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants