Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic for invalid strings #29

Closed
29ayush opened this issue Jan 24, 2024 · 2 comments · Fixed by #30
Closed

Panic for invalid strings #29

29ayush opened this issue Jan 24, 2024 · 2 comments · Fixed by #30

Comments

@29ayush
Copy link

29ayush commented Jan 24, 2024

If I try to decode string "No" for example I run into panic
https://go.dev/play/p/0rF2U4cLjce

Can you please return an error instead of panicking
@daku10 daku10 mentioned this issue Jan 24, 2024
Merged
@daku10
Copy link
Owner

daku10 commented Jan 24, 2024

@29ayush
Thanks for flagging this with the Go Playground link! Seeing a panic when decoding a string like "No" is definitely not ideal.

I created a new release with a fix for this issue.
Fix for this issue
New Release

Please try it out and let me know if you still see the same issue.
Thanks again for pointing this out!

@daku10 daku10 closed this as completed Jan 24, 2024
@29ayush
Copy link
Author

29ayush commented Jan 25, 2024

Awesome, thanks for the quick fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug decompression invalid string daku10/go-lz-string
2 participants
@29ayush @daku10