-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: deriving keys for x accounts instead of x addresses #20
Comments
Thx for the ledger path info. I think that the way to do this right would be to introduce a concept of path templates. So hd-wallet-derive would have a list of templates for various wallet software. I've considered doing this previously, but I figured I'd wait for a request. :-) I will see about adding path template code when I get some free time. If anyone can point me towards an accurate/current and hopefully maintained list of bip32 paths used by various wallet software, that would be super helpful. |
Glad to know you already have that in mind. This is what I was able to find for Trezor, but unfortunately, it's not a comprehensive list: maybe @prusnak could help? |
Oh, I just spotted this. Interesting. x is in the middle of the path, not the end. So supporting ledger-live is more than just a path preset, it is actually about iterating elsewhere, which requires a change to the core derivation code, path verification, etc. I'll have to take a look if there are any gotchas preventing it. |
Yes I tried to place it in the middle but got an error. Ledger says they made this decision for privacy reasons. |
@twfink I just added support for using x or x' in the middle of a path. (algo change in a202759) If you have a chance please give master a try with ledger live and let me know it works or if any issues. edit: preset templates are not implemented yet, but I did provide examples for Ledger Live and Trezor in the usage text. |
Thank you! I'll test once my new Ledger arrives in about two weeks. |
Implemented path presets (with 26 presets defined) in df220b5. Closing this. |
Thanks for this great tool. This suggestion would save Ledger users some time and effort
MyCryptoHQ/MyCrypto#2070
LedgerHQ/ledger-live-desktop#1185
Currently, Ledger users have to execute the command for each account with the path fully specified.
The text was updated successfully, but these errors were encountered: