Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release without "RC" in version number #367

Closed
tahoell opened this issue Jul 10, 2019 · 7 comments
Closed

Release without "RC" in version number #367

tahoell opened this issue Jul 10, 2019 · 7 comments
Labels

Comments

@tahoell
Copy link

tahoell commented Jul 10, 2019

Hi everybody,

we would like to use openhtmltopdf in our project. Unfortunatly our customer only allow us to use libraries, that don't contain "RC" in the version number. Would it be possibly to make a release without "RC" in a version number, for example "0.0.1"? It would be even better if the version number did not contain "0" in the second position, such as "0.1.0".
Would it be possible?
Thank you!

@ieugen
Copy link
Contributor

ieugen commented Jul 10, 2019

Hi @tahoell

I'm not a developer with Openhtmltopdf so I don't speak for them.
Hoever
This is an open source project. You can and should build your own releases if this does not suit you.
You can version those however you want but that won't change the fact that this software comes with no warranties or is not considered, by the authors - feature complete = version 1.0 ready.

@tahoell
Copy link
Author

tahoell commented Jul 12, 2019

Hello @ieugen

Thank you for the quick reply! Unfortunately for contractual reasons we can't use open source libraries that we build ourselves.

We would still like to use the library, because it would really help us. What do developers think about this?

@danfickle
Copy link
Owner

I think a v1 release for the PDF functionality is probably reasonable. It has a couple of hundred tests and I think people are using it in production. The problem is the java2d output side which has no tests and is bit rotting as we add features to the PDF side. I'm not sure what to do with this module.

Anyway, I'm inclined to do the v1 release (with a note about java2d output not meeting this standard) unless there are objections. @tahoell when do you need the release by? I'd like a week or so to get the work in replaced_sizing branch finished and merged.

@tahoell
Copy link
Author

tahoell commented Jul 13, 2019

Hi @danfickle
That's great! One week is perfect. Thank you very much for your quick help, I really appreciate it!

@lperdigao
Copy link

Hey guys! Thank you for the good work you've been doing so far. We would benefit a lot on a v1 release as well. Any update when you are able to do a release :) ?
Thanks in advance
Luis

@danfickle
Copy link
Owner

Release planned for tomorrow!

@danfickle
Copy link
Owner

Version 1.0.0 has just been sent to maven central! Enjoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants