Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CHANGELOG #276

Closed
tbassetto opened this issue Jul 23, 2014 · 4 comments
Closed

Update the CHANGELOG #276

tbassetto opened this issue Jul 23, 2014 · 4 comments
Labels

Comments

@tbassetto
Copy link

Hi,

Any chance that you could update the https://github.com/danialfarid/angular-file-upload/blob/master/CHANGELOG.md?

I updated from version 1.4.x to 1.6 and several things are now broken (like ng-file-drag-over-class not being applied). It's not obvious to not what changed or what the upgrade path is.

@tbassetto
Copy link
Author

The ng-file-drag-over-class directive in your demo is working so I tried to dive into the code to see what the issue could be. It turns out that in the version 1.5.0 your changed quite a bit the content of the dragover event callback and the code starting from this line is the issue: https://github.com/danialfarid/angular-file-upload/blob/61b1fa7026ea5597d33cd2c78c910ecabd331d2e/dist/angular-file-upload.js#L212

$parse() will always return a function so the next line will always be true and elem[0].__drag_over_class_ = attr['ngFileDragOverClass'] || "dragover"; will never be executed :/

@danialfarid
Copy link
Owner

You can see the history of changes in here: https://github.com/danialfarid/angular-file-upload/releases
I will try to update that though.
Thanks for finding the bug.

@danialfarid
Copy link
Owner

Fixed in version 1.6.2

@tbassetto
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants