Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera roll with 2000+ photos = Picture selector unusable #211

Open
thierrybucco opened this issue Oct 24, 2016 · 4 comments
Open

Camera roll with 2000+ photos = Picture selector unusable #211

thierrybucco opened this issue Oct 24, 2016 · 4 comments

Comments

@thierrybucco
Copy link

Hi,

My iPad has 2000+ photos, when I touch camera roll button it took almost 10 seconds to display content.

@jpros
Copy link

jpros commented Nov 10, 2016

I ended up using ReactiveObjc and the new Photos framework to achieve a better performance.

The new Photos framework gives me the photos ordered by date latest first, and the ReactiveObjC gives me the ability to add the photos in batches, and not load all of them to only then show to the user.

I've also added video browsing through DBCamera.

I'll clean up the code, and I should submit it soon.

@jpros
Copy link

jpros commented Nov 10, 2016

Duplicate from #206

@thelordy
Copy link

Ok guys, just fixed the issue. You have to make some changes on this files:

"DBLibraryManager.m":

On Line 86 ( before 'if ( group )') add:
ALAssetsFilter *onlyPhotosFilter = [ALAssetsFilter allPhotos];
[group setAssetsFilter:onlyPhotosFilter];

Replace Lines from 113 to 119 with:
if ( result ) {
[items addObject:result];
assetResult = result;
}

"DBCameraCollectionViewController.m":

Replace Lines from 74 to 78 with:
ALAsset *asset = _items[indexPath.item];
CGImageRef thumbnailImageRef = [asset thumbnail];
UIImage *thumbnail = [UIImage imageWithCGImage:thumbnailImageRef];
item.itemImage.image = thumbnail;

Replace Line 93 with:
[_collectionControllerDelegate collectionView:collectionView itemURL:(NSURL *)[[asset defaultRepresentation] url]];

Hope to help someone else because this library is amazing!

@thierrybucco
Copy link
Author

is it possible to do a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants