Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter Chart View V3.0 bad point displayed with BaloonMaker #1482

Closed
thierryH91200 opened this issue Sep 19, 2016 · 5 comments
Closed

Scatter Chart View V3.0 bad point displayed with BaloonMaker #1482

thierryH91200 opened this issue Sep 19, 2016 · 5 comments

Comments

@thierryH91200
Copy link
Contributor

macOS V3.0 Xcode 8.0

  • to "Scatter Chart View" I created a BaloonMaker and when I click on a point on the graph is another point of the y axis is displayed
  • some items have no values

it's all

thanks

            let  marker : BalloonMarker = BalloonMarker( color: #colorLiteral(red: 0.8039215803, green: 0.8039215803, blue: 0.8039215803, alpha: 1), font: NSFont.systemFont(ofSize: 12.0),  textColor: NSColor.white, insets: NSEdgeInsetsMake(8.0, 8.0, 20.0, 8.0))
            marker.minimumSize = CGSize( width: 80.0, height :40.0)
            scatterChartView.marker = marker

capture d ecran 2016-09-19 a 20 30 53

@thierryH91200 thierryH91200 changed the title Scatter Chart View V3.0 bad point displayed with BallonMaker Scatter Chart View V3.0 bad point displayed with BaloonMaker Sep 19, 2016
@danielgindi
Copy link
Collaborator

It seems like the highlight is also in the incorrect position. But cannot reproduce this problem. Can you upload a sample project?

@thierryH91200
Copy link
Contributor Author

Attached is an example of "scatter" based on os x Demo here is always the same point that is displayed with balloon marker
ChartsDemo-OSX.zip

thank you

@danielgindi
Copy link
Collaborator

@PhilJay There are two issues here, where the root of the problem is the fact that there are multiple values on same x-index.

  1. The searching algorithm (Which I've fixed on both platforms)
  2. The highlighter does not take this into account. We need to think about this for scatter and bubble charts where it makes sense to have multiple y-values for the same x-value

@PhilJay
Copy link
Collaborator

PhilJay commented Sep 22, 2016

Yes, the fix was really required, I had just started fixing it myself when I saw your PR.
So I just committed my test case that I wrote for the fix and your PR passed :-)

The highlighters are an issue still. Do you want to tackle this before the release?

@danielgindi
Copy link
Collaborator

I'm not sure if this is a must - but it did work for bubbles before 3.0, so I guess we're supposed to :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants