Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 3.1 Build #2287

Closed
cliftonlabrum opened this issue Mar 27, 2017 · 10 comments
Closed

Swift 3.1 Build #2287

cliftonlabrum opened this issue Mar 27, 2017 · 10 comments

Comments

@cliftonlabrum
Copy link

Xcode 8.3 is out now, along with Swift 3.1. The iOS Charts module won't build without downgrading the swift version.

Can we please get a Swift 3.1 build of this? Thank you! :)

@cliftonlabrum
Copy link
Author

Actually, never mind on the swift version downgrade. It doesn't look like that's possible.

@cliftonlabrum
Copy link
Author

It looks like there's an Xcode 8.3 branch: https://github.com/danielgindi/Charts/tree/xcode-8.3

I'll give that a try and see if it works.

@ronflima
Copy link

I found that it can be compiled, but with a bunch of warnings, most of them deprecation warnings.

@txaiwieser
Copy link

Great, gonna try this branch then! 👍

@cliftonlabrum
Copy link
Author

Has anyone done a Carthage build with the 8.3 branch? That's all I'm after. :)

@ronflima
Copy link

I have added this stuff as a dependency to my project using git submodules. It came to compile in tag 3.0.1 but with a bunch of warnings.

@txaiwieser
Copy link

Yes, I'm using Carthage and just built the branch "xcode-8.3"

@ronflima
Copy link

Upgraded to the xcode-8.3 branch also. Compiled just fine.

@krystianpaszek
Copy link

krystianpaszek commented Mar 27, 2017

Just used Carthage to build "xcode-8.3" branch and it worked well. Took a lot of time, though. To build this branch, use github "danielgindi/Charts" "xcode-8.3" in your Cartfile and then execute carthage update Charts --platform iOS in the command line.

@cliftonlabrum
Copy link
Author

Got it. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants