Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 3 (now targeted at the Swift-3.0 branch) #1171

Merged
merged 2 commits into from
Jul 4, 2016

Conversation

pixelspark
Copy link
Contributor

Like #1169, but targeted at the Swift-3.0 branch in the main repository.

@acegreen
Copy link

@pixelspark did you test your swift3 branch from your fork? I just tried it and there were a ton of open issues (iOS deployement)

@pixelspark
Copy link
Contributor Author

@acegreen I just committed fixes for compilation errors on iOS and tvOS (39cdf63). All should be fine now.

@acegreen
Copy link

@pixelspark just tried it out, works as expected

@liuxuan30
Copy link
Member

liuxuan30 commented Jul 4, 2016

@pixelspark @acegreen thanks, I will merge this

@liuxuan30 liuxuan30 merged commit b713620 into ChartsOrg:Swift-3.0 Jul 4, 2016
@acegreen
Copy link

acegreen commented Jul 6, 2016

@pixelspark @liuxuan30 there are some new issues with Xcode 8-beta 2

@liuxuan30
Copy link
Member

@acegreen able to help :)?

@acegreen
Copy link

acegreen commented Jul 6, 2016

@liuxuan30 done #1227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants