Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a podspec #13

Merged
merged 1 commit into from
Apr 8, 2015
Merged

Added a podspec #13

merged 1 commit into from
Apr 8, 2015

Conversation

pmairoldi
Copy link
Collaborator

I've added a podspec since I will be using this with cocoapods. I have not pushed it to the repo that manages pods just yet since the current specification is not complete. Cocoapods requires that a version be tagged in order to work properly and be able to distinguish between versions. I have done this in my own fork and used my fork as the source for the pod but I'd like it to point to the original source.

Once you tag a version, I will update this line: s.source = { :git => "https://github.com/petester42/ios-charts.git", :tag => "0.0.1" } to point to here and then you can merge.

I also tried making sure carthage support works but the way the current project is setup makes it so that the schemes are not there when running carthage.

@danielgindi
Copy link
Collaborator

Please clean this pull request first

@pmairoldi
Copy link
Collaborator Author

all cleaned up

@danielgindi
Copy link
Collaborator

Ok man now you can update the spec to this:

Pod::Spec.new do |s|
  s.name         = "Charts"
  s.version      = "2.0.9"
  s.summary      = "ios-charts is a powerful & easy to use charting library for iOS"
  s.homepage     = "https://github.com/danielgindi/ios-charts"
  s.license      = { :type => "Apache License, Version 2.0", :file => "LICENSE" }
  s.authors      = "Daniel Cohen Gindi", "Philipp Jahoda"
  s.platform     = :ios
  s.ios.deployment_target = '7.0'
  s.source       = { :git => "https://github.com/danielgindi/ios-charts.git", :tag => "v2.0.9" }
  s.source_files = "Classes", "Charts/Classes/**/*.swift"
  s.frameworks = 'Foundation', 'UIKit', 'CoreGraphics'
end

Squash the commits together and I'll pull it.

@pmairoldi
Copy link
Collaborator Author

Sadly iOS 7 is not supported for swift frameworks. It gives the following error:

-> Charts (2.0.9) - ERROR | [iOS] Swift support uses dynamic frameworks and is therefore only supported on iOS > 8.

It is also detailed on the cocoa pods blog under the availability section of this article http://blog.cocoapods.org/Pod-Authors-Guide-to-CocoaPods-Frameworks/

I will make the other changes but it has to stay iOS 8 for the pod.

@danielgindi
Copy link
Collaborator

@pmairoldi
Copy link
Collaborator Author

It's not a swift issue. Swift will work fine on iOS 7. The problem is the framework. Dynamic frameworks are only supported as of iOS 8. This builds a dynamic framework so no iOS 7 love :(. If someone want to use this on iOS 7 they will need to copy the files to their project and not use the framework.

danielgindi added a commit that referenced this pull request Apr 8, 2015
@danielgindi danielgindi merged commit 7df9bf4 into ChartsOrg:master Apr 8, 2015
@danielgindi
Copy link
Collaborator

Ok I see!
Thanks!
Merged.

@pmairoldi
Copy link
Collaborator Author

I've pushed the pod to trunk. If you want to be added as an owner of the pod just register with cocoapods pod trunk register email 'name' and i'll add you as an owner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants