-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a podspec #13
Added a podspec #13
Conversation
Please clean this pull request first |
all cleaned up |
Ok man now you can update the spec to this:
Squash the commits together and I'll pull it. |
Sadly iOS 7 is not supported for swift frameworks. It gives the following error:
It is also detailed on the cocoa pods blog under the availability section of this article http://blog.cocoapods.org/Pod-Authors-Guide-to-CocoaPods-Frameworks/ I will make the other changes but it has to stay iOS 8 for the pod. |
Are you sure it's not supported? |
It's not a swift issue. Swift will work fine on iOS 7. The problem is the framework. Dynamic frameworks are only supported as of iOS 8. This builds a dynamic framework so no iOS 7 love :(. If someone want to use this on iOS 7 they will need to copy the files to their project and not use the framework. |
Ok I see! |
I've pushed the pod to trunk. If you want to be added as an owner of the pod just register with cocoapods |
I've added a podspec since I will be using this with cocoapods. I have not pushed it to the repo that manages pods just yet since the current specification is not complete. Cocoapods requires that a version be tagged in order to work properly and be able to distinguish between versions. I have done this in my own fork and used my fork as the source for the pod but I'd like it to point to the original source.
Once you tag a version, I will update this line:
s.source = { :git => "https://github.com/petester42/ios-charts.git", :tag => "0.0.1" }
to point to here and then you can merge.I also tried making sure carthage support works but the way the current project is setup makes it so that the schemes are not there when running carthage.