Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileprivate -> private #3042

Merged
merged 2 commits into from
Dec 8, 2017
Merged

fileprivate -> private #3042

merged 2 commits into from
Dec 8, 2017

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Nov 23, 2017

almsot all cases of fileprivate were meant to be private. If there is a need to use fileprivate in the future, it should be considered then. Not now.

almsot all cases of fileprivate were meant to be private. If there is a need to use fileprivate in the future, it should be considered then. Not now.
@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #3042 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3042   +/-   ##
=======================================
  Coverage   19.64%   19.64%           
=======================================
  Files         113      113           
  Lines       13508    13508           
=======================================
  Hits         2653     2653           
  Misses      10855    10855
Impacted Files Coverage Δ
Source/Charts/Charts/ChartViewBase.swift 23.09% <ø> (ø) ⬆️
Source/Charts/Utils/Fill.swift 0% <ø> (ø) ⬆️
Source/Charts/Charts/RadarChartView.swift 0% <ø> (ø) ⬆️
Source/Charts/Charts/PieRadarChartViewBase.swift 0% <ø> (ø) ⬆️
...plementations/Standard/LineRadarChartDataSet.swift 16.66% <ø> (ø) ⬆️
Source/Charts/Components/YAxis.swift 79.66% <ø> (ø) ⬆️
Source/Charts/Renderers/PieChartRenderer.swift 0% <ø> (ø) ⬆️
...a/Implementations/Standard/BarChartDataEntry.swift 2.3% <ø> (ø) ⬆️
Source/Charts/Components/ChartLimitLine.swift 0% <ø> (ø) ⬆️
Source/Charts/Renderers/XAxisRenderer.swift 58.5% <ø> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f74a25...0176e15. Read the comment docs.

@jjatie
Copy link
Collaborator Author

jjatie commented Nov 24, 2017

@liuxuan30 This is a quick and easy one.

@liuxuan30 liuxuan30 self-requested a review December 5, 2017 02:24
@liuxuan30
Copy link
Member

liuxuan30 commented Dec 7, 2017

@danielgindi @petester42 do you remember why use fileprivate back then? I don't find a private var in file scope; all in class scope, so using private seems reasonable. Not sure if we need access in file range.

@liuxuan30
Copy link
Member

when we need fileprivate, we could add them later.

@liuxuan30 liuxuan30 merged commit 8c9d5f3 into ChartsOrg:master Dec 8, 2017
@jjatie jjatie deleted the fileprivate-to-private branch December 8, 2017 13:33
@pmairoldi
Copy link
Collaborator

Probably because private was not needed and the semantics were a little different back then.

FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request Jan 2, 2018
* 'master' of https://github.com/danielgindi/Charts: (23 commits)
  Update ViewPortHandler.swift (ChartsOrg#3143)
  add option to build demo projects unit tests on iOS (ChartsOrg#3121)
  Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994)
  Update 4.0.0 with master (ChartsOrg#3135)
  Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043)
  fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874)
  Makes ChartsDemo compiling again (ChartsOrg#3117)
  Fixed using wrong axis (Issue ChartsOrg#2257)
  Removed methods and properties deprecated in 1.0 (ChartsOrg#2996)
  for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing
  The backing var is not necessary. (ChartsOrg#3000)
  Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoint` (ChartsOrg#2993)
  Minor logic cleanup (ChartsOrg#3041)
  Fix a bug may cause infinite loop. (ChartsOrg#3073)
  for ChartsOrg#2745. chart should be weak.
  fileprivate -> private (ChartsOrg#3042)
  Removed `isKind(of:)`
  Removed @objc from internal properties
  Fixes for PR
  Made use of `==` where appropriate to simplify logic
  ...

# Conflicts:
#	Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift
#	Source/Charts/Renderers/BarChartRenderer.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants