Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call chartViewDidEndPanning on when *panning* is ended #4271

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

danielgindi
Copy link
Collaborator

Goals ⚽

Straighten the semantics of the event.

Implementation Details 🚧

Currently the relatively new protocol method is called in the end of the gesture, even if the gesture does not mean "pan". This could cause unexpected bugs.

@danielgindi danielgindi merged commit c9ab42f into master Jan 23, 2020
@danielgindi danielgindi deleted the bugfix/chartViewDidEndPanning branch January 24, 2020 07:44
@odanu
Copy link

odanu commented Apr 21, 2020

It looks like this PR introduced a regression. The chartViewDidEndPanning stopped being called when user finishes the interaction with the chart.

@odanu
Copy link

odanu commented Apr 21, 2020

In the latest version it looks like that chartViewDidEndPanning might be called only and only when __isDragging is true.
Code comments say that isDragging is true when:

// If drag is enabled and we are in a position where there's something to drag:
            //  * If we're zoomed in, then obviously we have something to drag.
            //  * If we have a drag offset - we always have something to drag

But, panning is not always dragging.

@liuxuan30
Copy link
Member

liuxuan30 commented Dec 31, 2021

reverted.

liuxuan30 added a commit that referenced this pull request Dec 31, 2021
…ent_scrollView_on_dragging

Revert #4271 and disable parent scroll view on dragging
taykay08 added a commit to bigskyhealth/Charts that referenced this pull request Apr 18, 2022
…ase-master-update

* 'master' of https://github.com/danielgindi/Charts:
  bump pod version
  Update project settings to support publishing pod
  Revert ChartsOrg#4271 and disable parent scroll view on dragging
rcblue added a commit to rcblue/Charts that referenced this pull request Jan 6, 2023
rcblue added a commit to rcblue/Charts that referenced this pull request Jan 6, 2023
…ent_scrollView_on_dragging

Revert ChartsOrg/Charts#4271 and disable parent scroll view on dragging
mmazzei pushed a commit to mmazzei/Charts that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants