Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit #16

Closed
marioedgar opened this issue Jan 3, 2020 · 4 comments
Closed

npm audit #16

marioedgar opened this issue Jan 3, 2020 · 4 comments

Comments

@marioedgar
Copy link

Im see security vulnerabilities on npm install:

Screen Shot 2020-01-02 at 8 34 13 PM

@danielkellyio
Copy link
Owner

See if an ‘npm audit —fix’ takes care of it. If so feel free to submit a PR. Thanks!

@marioedgar
Copy link
Author

OK so i took a stab at this. Looks like the audit fix will cause a mismatch in vue.js versions:

Steps i took:

npm audit fix
...
...
fixed 20 of 20 vulnerabilities in 20676 scanned packages

Ran the project:

npm run dev

I now get the following error:

Screenshot from 2020-01-23 19-17-50

The first thing i tried after this, was to update nuxt.js

npm i nuxt@latest --save

I got the same mismatch error after this as well.

@marioedgar
Copy link
Author

marioedgar commented Jan 24, 2020

ok, I got this fixed. I tried to open a pull request but it said i dont have permission. Here are the steps i did to fix:

npm audit fix
npm install vue@latest --save
npm install vue-server-renderer@latest --save

According to this, just need to lock down the versions of vue and the server renderer:

nuxt/nuxt#1084

Side note - Running this on linux gave me some errors due to too many watchers. Not sure if thats my system or the code.

@danielkellyio
Copy link
Owner

thanks @marioedgar for the work on this. Updated and specified the vue and vue-server-renderer in this commit: 1dd1922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants