Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error/reject handler is invoked when launch-navigator.navigate fails #4383

Closed
ryaa opened this issue Oct 18, 2022 · 1 comment · Fixed by #4385
Closed

No error/reject handler is invoked when launch-navigator.navigate fails #4383

ryaa opened this issue Oct 18, 2022 · 1 comment · Fixed by #4385

Comments

@ryaa
Copy link
Contributor

ryaa commented Oct 18, 2022

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use the discussions section https://github.com/danielsogl/awesome-cordova-plugins/discussions

Current behavior:
When launch-navigator.navigate fails (for example see ionic-team/capacitor#6002) the the promise catch is never invoked. Please note that the promise success is also never invoked if all work well

Expected behavior:
When launch-navigator.navigate is invoked, as a result, it should invoke either success/resolve or error/reject clause.
It seems that this change broke the success/error handling.
The succes/error handler should be 1/2 and not 2/3 - see https://github.com/danielsogl/awesome-cordova-plugins/blob/master/src/%40awesome-cordova-plugins/plugins/launch-navigator/index.ts#L324 and https://github.com/dpa99c/phonegap-launch-navigator#navigate (note launchnavigator.navigate(destination, successCallback, errorCallback, options);)

Steps to reproduce:
See ionic-team/capacitor#6002

Other information:
N/A

@ryaa
Copy link
Contributor Author

ryaa commented Oct 18, 2022

Here is the PR which should fix this problem #4385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant